Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add instructions to list all plugins in krew caveat section #156

Merged
merged 3 commits into from May 31, 2019

Conversation

Projects
None yet
3 participants
@corneliusweig
Copy link
Contributor

commented May 30, 2019


Checklist for plugin developers:

  • Read the Plugin Naming Guide (for new plugins)
  • Verify the installation from URL or a local archive works (kubectl krew install --manifest=[...] --archive=[...])

corneliusweig added some commits May 30, 2019

Change the location of krew to sigs.k8s.io
Note that the link to the naming-guide must not contain 'tree/master'.

Signed-off-by: Cornelius Weig <cornelius.weig@gmail.com>
Add hint to run `krew search` for a list of all plugins
Signed-off-by: Cornelius Weig <cornelius.weig@gmail.com>
Show resolved Hide resolved plugins/krew.yaml Outdated
Improve punctuation
Signed-off-by: Cornelius Weig <cornelius.weig@gmail.com>
@ahmetb

This comment has been minimized.

Copy link
Contributor

commented May 31, 2019

/lgtm
/approve

@k8s-ci-robot

This comment has been minimized.

Copy link

commented May 31, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmetb, corneliusweig

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 532a299 into kubernetes-sigs:master May 31, 2019

2 of 3 checks passed

tide Not mergeable.
Details
cla/linuxfoundation corneliusweig authorized
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.