Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

virt: Adjust wording #160

Merged
merged 2 commits into from Jun 11, 2019

Conversation

Projects
None yet
4 participants
@fabiand
Copy link
Contributor

commented Jun 11, 2019

This change is adjusting the wording in order to make the plugin discoverable
and alignt he language.

Signed-off-by: Fabian Deutsch fabiand@fedoraproject.org

virt: Adjust wording
This change is adjusting the wording in order to make the plugin discoverable
and alignt he language.

Signed-off-by: Fabian Deutsch <fabiand@fedoraproject.org>
@k8s-ci-robot

This comment has been minimized.

Copy link

commented Jun 11, 2019

Welcome @fabiand!

It looks like this is your first PR to kubernetes-sigs/krew-index 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/krew-index has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@@ -35,11 +35,11 @@ spec:
- from: "/virtctl/virtctl-v0.17.2-darwin-amd64"
to: "virtctl"
bin: "virtctl"
shortDescription: controls virtual machine related operations.
shortDescription: Control KubeVirt Virtual Machines

This comment has been minimized.

Copy link
@corneliusweig

corneliusweig Jun 11, 2019

Contributor

I understand the camel-case for "KubeVirt", but "virtual machines" is just plain English and can be lower-case, right? Also, I think the short description could hint that this is a wrapper around virtctl

Suggested change
shortDescription: Control KubeVirt Virtual Machines
shortDescription: Control KubeVirt virtual machines using virtctl

This comment has been minimized.

Copy link
@fabiand

fabiand Jun 11, 2019

Author Contributor

Both good points, I'll address them. Thanks.

This comment has been minimized.

Copy link
@fabiand

fabiand Jun 11, 2019

Author Contributor

(Added a new commit as it suites my flow better)

virt: Follow suggestion
Signed-off-by: Fabian Deutsch <fabiand@fedoraproject.org>
@ahmetb

This comment has been minimized.

Copy link
Contributor

commented Jun 11, 2019

/lgtm
/approve

@k8s-ci-robot

This comment has been minimized.

Copy link

commented Jun 11, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmetb, fabiand

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 9de9efb into kubernetes-sigs:master Jun 11, 2019

2 of 3 checks passed

tide Not mergeable.
Details
cla/linuxfoundation fabiand authorized
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@fabiand

This comment has been minimized.

Copy link
Contributor Author

commented Jun 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.