Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PR template #17

Merged
merged 1 commit into from Aug 20, 2018

Conversation

Projects
None yet
3 participants
@ahmetb
Copy link
Contributor

commented Aug 13, 2018

It takes effect below in this PR :)

/cc @lbb


Checklist for plugin developers:

  • Read the Plugin Naming Guide
  • Verify the installation from URL works (kubectl plugin install --source)
Add PR template
Signed-off-by: Ahmet Alp Balkan <ahmetb@google.com>

@ahmetb ahmetb force-pushed the ahmetb:pr-template branch from c7f2538 to b8d5706 Aug 13, 2018

@lbb

lbb approved these changes Aug 13, 2018

Copy link
Contributor

left a comment

\o/ I like it.

@lbb

This comment has been minimized.

Copy link
Contributor

commented Aug 20, 2018

/cc @ahmetb

@ahmetb ahmetb merged commit e7b4daa into kubernetes-sigs:master Aug 20, 2018

1 check passed

cla/google All necessary CLAs are signed

corneliusweig added a commit to corneliusweig/krew-index that referenced this pull request Mar 25, 2019

Update plugin "get-all" to v1.1.0
Release notes:

* Flag `--namespace` now implies `--only-scope=namespace`
[kubernetes-sigs#18](corneliusweig/ketall#18)
* Add new flag `--since` to filter resources by creation timestamp
[kubernetes-sigs#17](corneliusweig/ketall#17)
* Fix travis releases
[#15](corneliusweig/ketall#15)

corneliusweig added a commit to corneliusweig/krew-index that referenced this pull request Mar 25, 2019

Update plugin "get-all" to v1.1.0
Release notes:

* Flag `--namespace` now implies `--only-scope=namespace`
[kubernetes-sigs#18](corneliusweig/ketall#18)
* Add new flag `--since` to filter resources by creation timestamp
[kubernetes-sigs#17](corneliusweig/ketall#17)
* Fix travis releases
[#15](corneliusweig/ketall#15)

Signed-off-by: Cornelius Weig <22861411+corneliusweig@users.noreply.github.com>

corneliusweig added a commit to corneliusweig/krew-index that referenced this pull request Mar 25, 2019

Update plugin "get-all" to v1.1.0
Release notes:

* Flag `--namespace` now implies `--only-scope=namespace`
[kubernetes-sigs#18](corneliusweig/ketall#18)
* Add new flag `--since` to filter resources by creation timestamp
[kubernetes-sigs#17](corneliusweig/ketall#17)
* Fix travis releases
[#15](corneliusweig/ketall#15)

Signed-off-by: Cornelius Weig <22861411+corneliusweig@users.noreply.github.com>

ahmetb added a commit that referenced this pull request Mar 25, 2019

Update plugin "get-all" to v1.1.0 (#119)
Release notes:

* Flag `--namespace` now implies `--only-scope=namespace`
[#18](corneliusweig/ketall#18)
* Add new flag `--since` to filter resources by creation timestamp
[#17](corneliusweig/ketall#17)
* Fix travis releases
[#15](corneliusweig/ketall#15)

Signed-off-by: Cornelius Weig <22861411+corneliusweig@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.