Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add plugin list page #202

Merged
merged 1 commit into from Aug 16, 2019

Conversation

@ahmetb
Copy link
Member

commented Aug 15, 2019

Introduces a lightweight plugins.md that can be linked in onboarding docs
at the "krew" repo as well as this "krew-index" repo.

Supersedes kubernetes-sigs/krew#303.

Add plugin list page
Introduces a lightweight plugins.md that can be linked in onboarding docs
at the "krew" repo as well as this "krew-index" repo.

Supersedes kubernetes-sigs/krew#303.

Signed-off-by: Ahmet Alp Balkan <ahmetb@google.com>
@corneliusweig

This comment has been minimized.

Copy link
Contributor

commented Aug 15, 2019

I was thinking about how to include this in krew-index but avoid distributing to our users. One idea would be to use git hash-object -w and then reference the object in an annotated tag, which is pushed to github. Then only users pulling all tags would get the object. Junio Hamano does a similar trick with his public gpg key for signing tags in git/git. I still have to explore though, if github can show the markdown file, though.

On second thought: maybe an easier approach is to have a dedicated branch where the plugins.md lives. I'm quite sure this does work :)

@ahmetb

This comment has been minimized.

Copy link
Member Author

commented Aug 15, 2019

The file is really small, like a plugin manifest. So I'm not too worried about it. It's like having a plugin that updates occassionally.

@corneliusweig

This comment has been minimized.

Copy link
Contributor

commented Aug 15, 2019

One final thought before merging: as this file is not automatically updated, I think we should include a disclaimer on top that this may be outdated -- and say what revision this file refers to. WDYT?

@ahmetb

This comment has been minimized.

Copy link
Member Author

commented Aug 15, 2019

Yeah that's possible, we should say run kubectl krew search for an up-to-date list. But that requires change in the tool, so we can do later.

@corneliusweig

This comment has been minimized.

Copy link
Contributor

commented Aug 16, 2019

/lgtm
/approve

@k8s-ci-robot

This comment has been minimized.

Copy link

commented Aug 16, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmetb, corneliusweig

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [ahmetb,corneliusweig]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 84f70da into kubernetes-sigs:master Aug 16, 2019

2 of 3 checks passed

tide Not mergeable. Needs lgtm label.
Details
cla/linuxfoundation ahmetb authorized
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.