Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump oidc-login to v1.14.3 #242

Merged
merged 1 commit into from Sep 11, 2019

Conversation

@int128
Copy link
Contributor

commented Sep 11, 2019

This bumps oidc-login to https://github.com/int128/kubelogin/releases/tag/v1.14.3

Tested on my mac.

% kubectl krew install --manifest ~/Downloads/oidc-login.yaml
Installing plugin: oidc-login
CAVEATS:
\
 |  You need to setup the OIDC provider, Kubernetes API server, role binding and kubeconfig.
 |  See https://github.com/int128/kubelogin for more.
/
Installed plugin: oidc-login

% kubectl oidc-login version
kubectl-oidc_login version v1.14.3

% kubectl get nodes
I0911 10:19:36.721513   12145 get_token.go:52] WARNING: log may contain your secrets such as token or password
...(snip)...
I0911 10:19:37.825653   12145 get_token.go:94] writing the token to client-go
NAME                                          STATUS   ROLES    AGE   VERSION
ip-172-20-48-39.us-west-2.compute.internal    Ready    master   9d    v1.13.10
ip-172-20-56-181.us-west-2.compute.internal   Ready    node     9d    v1.13.10
@ahmetb

This comment has been minimized.

Copy link
Member

commented Sep 11, 2019

🤖 Beep beep! I’m a robot speaking on behalf of @ahmetb. 🤖


This pull request seems to be a straightforward version bump.
I'll go ahead and accept it. 👍 Cheers.

/lgtm
/approve

@k8s-ci-robot

This comment has been minimized.

Copy link

commented Sep 11, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmetb, int128

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit cfd6023 into kubernetes-sigs:master Sep 11, 2019

2 of 3 checks passed

tide Not mergeable.
Details
cla/linuxfoundation int128 authorized
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.