Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use latest krew for CI manifest validation #250

Conversation

@corneliusweig
Copy link
Contributor

commented Sep 24, 2019

The platform selector was made optional in krew-0.3.0 and now defaults to

files:
- from: '*'
  to: '.'

However, we forgot to update the CI bits for krew-index here.

This helps with the failing build from #248

/cc @ahmetb

@corneliusweig corneliusweig force-pushed the corneliusweig:w/use-latest-krew-for-validate-manifest branch from 68aaffb to 5a8248b Sep 24, 2019
@ahmetb

This comment has been minimized.

Copy link
Member

commented Sep 25, 2019

/lgtm
/approve

@k8s-ci-robot

This comment has been minimized.

Copy link

commented Sep 25, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmetb, corneliusweig

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [ahmetb,corneliusweig]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit e8b9e4a into kubernetes-sigs:master Sep 25, 2019
2 of 3 checks passed
2 of 3 checks passed
tide Not mergeable.
Details
cla/linuxfoundation corneliusweig authorized
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@corneliusweig corneliusweig deleted the corneliusweig:w/use-latest-krew-for-validate-manifest branch Sep 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.