Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add node-ssm plugin #3071

Merged
merged 1 commit into from
May 19, 2023
Merged

add node-ssm plugin #3071

merged 1 commit into from
May 19, 2023

Conversation

VioletCranberry
Copy link
Contributor

A very simple plugin to enable direct connections to AWS EKS cluster SSM managed nodes.

Connections are initiated with local aws cli and systems-manager-plugin. EKS cluster node name is resolved to instance ID automatically, which eliminates the pain of leaving the shell and switching to console to look it up, especially if multiple clusters in multiple regions/profiles are involved.

Tested installation, followed best practises while writing the code.

❯ kubectl krew install --manifest=./plugins/node-ssm.yaml
Installing plugin: node-ssm
Installed plugin: node-ssm
\
 | Use this plugin:
 |      kubectl node-ssm
 | Documentation:
 |      https://github.com/VioletCranberry/kubectl-node-ssm
 | Caveats:
 | \
 |  | AWS SSM manager requires setup before you can connect to managed nodes.
 |  | This plugin requires:
 |  | * AWS CLI
 |  | * session-manager-plugin
 | /
/

I see we are going through a lot of troubles with naming the plugins, however I've chosen node-ssm as many people are associating SSM with AWS to make things clear about what this plugin does, and match commands appropriately (e.g. aws ssm start-session --target instance-id vs kubectl node-ssm start-session --target node-name).

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Apr 14, 2023

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: VioletCranberry / name: Fedor Zhdanov (4165278)

@ahmetb
Copy link
Member

ahmetb commented Apr 14, 2023

🤖 Beep beep! I’m a robot speaking on behalf of @ahmetb. 🤖


Thanks for submitting your kubectl plugin to Krew!
One of the krew-index maintainers will review it soon. Note that the reviews for new plugin submissions may take a few days.

In the meanwhile, here are a few tips to make your plugin manifest better:

  • Make sure your plugin follows the best practices.
  • Eliminate redundant wording form shortDescription (it should be max 50 characters).
  • Try to word wrap your description to 80-character lines (no usage examples, please).

Thanks for your patience!
/kind new-plugin

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. kind/new-plugin labels Apr 14, 2023
@k8s-ci-robot
Copy link
Contributor

Welcome @VioletCranberry!

It looks like this is your first PR to kubernetes-sigs/krew-index 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/krew-index has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Apr 14, 2023
@ahmetb
Copy link
Member

ahmetb commented May 19, 2023

/lgtm
/approve
Thanks! Sorry for the delay.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 19, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmetb, VioletCranberry

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 19, 2023
@k8s-ci-robot k8s-ci-robot merged commit a0a9367 into kubernetes-sigs:master May 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/new-plugin lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants