Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print validated files to stderr #391

Merged
merged 1 commit into from Dec 17, 2019
Merged

Conversation

@ahmetb
Copy link
Member

ahmetb commented Dec 17, 2019

Adding a pipe to tee /dev/stderr so that we can see which files are being
passed to validate-krew-manifest. Though, we print all files before validating
any of them, but still useful since mostly 1 plugin is updated at a time.

Adding a pipe to tee /dev/stderr so that we can see which files are being
passed to validate-krew-manifest. Though, we print all files before validating
any of them, but still useful since mostly 1 plugin is updated at a time.

Signed-off-by: Ahmet Alp Balkan <ahmetb@google.com>
@corneliusweig

This comment has been minimized.

Copy link
Contributor

corneliusweig commented Dec 17, 2019

Makes sense in principle. Another approach would be to enable debug logging for manifest validation. This could give us also other valuable hints if anything goes wrong.

/lgtm
/approve
/hold
Feel free to remove the hold label if you think debug logging is not a good idea.

@k8s-ci-robot

This comment has been minimized.

Copy link

k8s-ci-robot commented Dec 17, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmetb, corneliusweig

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [ahmetb,corneliusweig]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ahmetb

This comment has been minimized.

Copy link
Member Author

ahmetb commented Dec 17, 2019

I don't think we have much logs in manifest validator?

@corneliusweig

This comment has been minimized.

Copy link
Contributor

corneliusweig commented Dec 17, 2019

Hm.. somewhat true. I had a look and it's only 4 log statements that could be "unlocked".

One of those is the filename though.

@corneliusweig

This comment has been minimized.

Copy link
Contributor

corneliusweig commented Dec 17, 2019

/hold cancel

@k8s-ci-robot k8s-ci-robot merged commit c1a8e89 into kubernetes-sigs:master Dec 17, 2019
2 of 3 checks passed
2 of 3 checks passed
tide Not mergeable. Should not have do-not-merge/hold label.
Details
cla/linuxfoundation ahmetb authorized
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.