Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add pv-migrate plugin #89

Open
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
4 participants
@utkuozdemir
Copy link

commented Mar 9, 2019


Checklist for plugin developers:

  • Read the Plugin Naming Guide (for new plugins)
  • Verify the installation from URL or a local archive works (kubectl krew install --manifest=[...] --archive=[...])
@googlebot

This comment has been minimized.

Copy link

commented Mar 9, 2019

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

1 similar comment
@googlebot

This comment has been minimized.

Copy link

commented Mar 9, 2019

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@utkuozdemir

This comment has been minimized.

Copy link
Author

commented Mar 9, 2019

I signed it!

@googlebot

This comment has been minimized.

Copy link

commented Mar 9, 2019

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

1 similar comment
@googlebot

This comment has been minimized.

Copy link

commented Mar 9, 2019

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@ahmetb

This comment has been minimized.

Copy link
Contributor

commented Mar 11, 2019

Do you think this would be a tool that people would use frequently? We’re actively trying to avoid one-off scripts to be distributed as plugins.

@utkuozdemir

This comment has been minimized.

Copy link
Author

commented Mar 11, 2019

Hm, nope, it’s more of a one-off script. If you try to avoid those better leave this out - it’s fine.

@ahmetb ahmetb added the hold label Mar 11, 2019

@ahmetb

This comment has been minimized.

Copy link
Contributor

commented Apr 8, 2019

/hold

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.