Skip to content
Permalink
Browse files

Improve github action (#493)

* Improve github action

* whitespace (trim)
* better step naming

* Apply comments
  • Loading branch information
ferhatelmas committed Feb 6, 2020
1 parent 5826e5e commit 867ad1edf009a2e45baee03baa386d120a8ec8de
Showing with 22 additions and 25 deletions.
  1. +22 −25 .github/workflows/ci.yml
@@ -1,12 +1,12 @@
name: Kubernetes-sigs/krew CI
on:
on:
push:
branches:
branches:
- '*'
tags:
tags:
- 'v*.*.*'
pull_request:
branches:
branches:
- '*'

jobs:
@@ -23,47 +23,47 @@ jobs:

- name: Check out code into the Go module directory
uses: actions/checkout@v2
- name: Add GOPATH

- name: Add GOPATH/bin to PATH
run: echo "::add-path::$(go env GOPATH)/bin"

- name: Install dependencies
run: go mod download

- name: Install gox
run: hack/install-gox.sh
- name: Verify code quality

- name: Ensure go.mod is already tidied
run: go mod tidy && git diff --no-patch --exit-code

- name: Verify code patterns
run: hack/verify-code-patterns.sh

- name: Verify boilerplate
run: hack/verify-boilerplate.sh

- name: Run code lint
run: hack/run-lint.sh

- name: Run unit tests
run: go test -short -coverprofile=coverage.txt -covermode=atomic ./...

- name: Make binaries && verify krew installation
run: hack/make-all.sh

- name: Ensure kubectl installed
run: hack/ensure-kubectl-installed.sh

- name: Verify installation
run: hack/verify-installation.sh

- name: Run integration tests
run: hack/run-integration-tests.sh
- name: Receipts upgrade migrations

- name: Verify receipt migration from v0.2.x to v0.3.x
run: hack/verify-receipts-upgrade-migration.sh

- name: Create release
- name: Create a new release
if: contains(github.ref, 'tags')
id: create_release
uses: actions/create-release@v1.0.0
@@ -75,7 +75,7 @@ jobs:
draft: false
prerelease: false

- name: Upload binaries to release
- name: Upload binaries to the new release
if: contains(github.ref, 'tags')
uses: svenstaro/upload-release-action@v1-release
with:
@@ -84,6 +84,3 @@ jobs:
tag: ${{ github.ref }}
overwrite: true
file_glob: true



0 comments on commit 867ad1e

Please sign in to comment.
You can’t perform that action at this time.