Please sign in to comment.
pkg/installation: reorder receipt save & install() (#237)
* pkg/installation: reorder receipt save & install() Looks like we didn't address the code review comment at #195 (comment). Copying the conversation from there: > This is better because: > > - actually installing a plugin (extract files, symlink binary) but then failing > to store the receipt is okay (at most you'd be leaking some files) > - claiming the plugin is installed (i.e. receipt exists) while it's not > installed is not okay. > - tens of things can go wrong in `install()`, much fewer things can go wrong > in `receipt.Store()`, so makes sense to do it last. Signed-off-by: Ahmet Alp Balkan <firstname.lastname@example.org> * pkg/installation: reorder receipt saving in uninstall() Signed-off-by: Ahmet Alp Balkan <email@example.com>
- Loading branch information...