Skip to content
Permalink
Browse files

Fix handling when no matching platform is found (#345)

`err` is nil here, so errors.Wrapf(...) is nil too, so that the
calling code assumes that no error happened.
  • Loading branch information...
corneliusweig authored and k8s-ci-robot committed Sep 24, 2019
1 parent 641920a commit e88f854d794ad43433259f9802f6e4789e9d72e5
Showing with 1 addition and 1 deletion.
  1. +1 −1 pkg/installation/install.go
@@ -70,7 +70,7 @@ func Install(p environment.Paths, plugin index.Plugin, opts InstallOpts) error {
return errors.Wrap(err, "failed trying to find a matching platform in plugin spec")
}
if !ok {
return errors.Wrapf(err, "plugin %q does not offer installation for this platform", plugin.Name)
return errors.Errorf("plugin %q does not offer installation for this platform", plugin.Name)
}

// The actual install should be the last action so that a failure during receipt

0 comments on commit e88f854

Please sign in to comment.
You can’t perform that action at this time.