Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OWNERS, kubernetes project template files #161

Merged
merged 1 commit into from Mar 15, 2019

Conversation

Projects
None yet
5 participants
@codecov-io

This comment has been minimized.

Copy link

commented Mar 14, 2019

Codecov Report

Merging #161 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #161   +/-   ##
=======================================
  Coverage   50.91%   50.91%           
=======================================
  Files          13       13           
  Lines         711      711           
=======================================
  Hits          362      362           
  Misses        297      297           
  Partials       52       52

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c931212...5cab210. Read the comment docs.

Show resolved Hide resolved CONTRIBUTING.md Outdated

@ahmetb ahmetb force-pushed the ahmetb:kubernetes-template branch from 5c4cfc2 to 5cab210 Mar 14, 2019

@nikhita
Copy link
Member

left a comment

lgtm

@ahmetb ahmetb merged commit 3c0eced into kubernetes-sigs:master Mar 15, 2019

2 checks passed

cla/google All necessary CLAs are signed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@@ -0,0 +1,4 @@
aliases:
krew-index-maintainers:

This comment has been minimized.

Copy link
@rlenferink

rlenferink Mar 17, 2019

Member

I think the krew-maintainers and krew-index-maintainers were swapped by accident.

Probably this one should be krew-maintainers and this one 8888595ca25a7a48c303fbc07f369b2db9b95268/OWNERS_ALIASES#L2 should be krew-index-maintainers

This comment has been minimized.

Copy link
@ahmetb

ahmetb Mar 17, 2019

Author Contributor

Argh my bad. I think I’ll do both krew-maintainers if that makes it easier. I suspect we’ll revise them in the future again.

This comment has been minimized.

Copy link
@rlenferink

rlenferink Mar 18, 2019

Member

At the moment, it doesn't really matter. The teams in the OWNERS files need to be defined in the OWNERS_ALIASES file per repository. Till the moment we can use GitHub teams for this, it is necessary to have the data available in the OWNERS* files for both repositories.

So it is completely up to you if you want to 'combine' or keep the repositories separate (different contributors/maintainers).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.