Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate license boilerplate in CI builds #183

Merged

Conversation

Projects
None yet
4 participants
@corneliusweig
Copy link
Contributor

commented May 9, 2019

Also fix the copyright notice where necessary.

Fix #173

corneliusweig added some commits May 9, 2019

Fix copyright notice in Dockerfile
In order for the Dockerfile to be picked up by the validator, it needs to be renamed Dockerfile.build->Dockerfile
@codecov-io

This comment has been minimized.

Copy link

commented May 9, 2019

Codecov Report

Merging #183 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #183   +/-   ##
=======================================
  Coverage   50.91%   50.91%           
=======================================
  Files          13       13           
  Lines         711      711           
=======================================
  Hits          362      362           
  Misses        297      297           
  Partials       52       52
Impacted Files Coverage Δ
pkg/version/version.go 100% <ø> (ø) ⬆️
cmd/validate-krew-manifest/main.go 37.63% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 59d76f3...1bdf39b. Read the comment docs.

@@ -16,7 +16,7 @@
# as well as "latest"
steps:
- name: 'gcr.io/cloud-builders/docker'
args: ['build', '-t', 'builder', '-f', 'hack/Dockerfile.build', '.']
args: ['build', '-t', 'builder', '-f', 'hack/Dockerfile', '.']

This comment has been minimized.

Copy link
@ahmetb

ahmetb May 9, 2019

Contributor

this seems like an unrelated change?

This comment has been minimized.

Copy link
@corneliusweig

corneliusweig May 9, 2019

Author Contributor

I explained in the commit message: if the Dockerfile has this non-standard name, it is not picked up by the license boilerplate validation.

@ahmetb

This comment has been minimized.

Copy link
Contributor

commented May 9, 2019

/lgtm
Left a few comments. If we can indicate where did these scripts come from (so the future maintainers go there to grab newer versions) it would be the most ideal solution.

@k8s-ci-robot k8s-ci-robot removed the lgtm label May 9, 2019

@ahmetb

This comment has been minimized.

Copy link
Contributor

commented May 10, 2019

/lgtm
/approve

Thanks!

@k8s-ci-robot k8s-ci-robot added the lgtm label May 10, 2019

@k8s-ci-robot

This comment has been minimized.

Copy link

commented May 10, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmetb, corneliusweig

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 2ac6aa0 into kubernetes-sigs:master May 10, 2019

2 of 3 checks passed

tide Not mergeable. Needs approved, lgtm labels.
Details
cla/linuxfoundation corneliusweig authorized
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@corneliusweig corneliusweig deleted the corneliusweig:pr/boilerplate-test branch May 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.