Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added link for contribution doc #207

Merged
merged 3 commits into from Jun 6, 2019

Conversation

Projects
None yet
5 participants
@hpandeycodeit
Copy link
Contributor

commented Jun 5, 2019

Issue #204

@k8s-ci-robot

This comment has been minimized.

Copy link

commented Jun 5, 2019

Welcome @hpandeycodeit!

It looks like this is your first PR to kubernetes-sigs/krew 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/krew has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@codecov-io

This comment has been minimized.

Copy link

commented Jun 5, 2019

Codecov Report

Merging #207 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #207   +/-   ##
=======================================
  Coverage   53.77%   53.77%           
=======================================
  Files          13       13           
  Lines         716      716           
=======================================
  Hits          385      385           
  Misses        279      279           
  Partials       52       52

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3859076...69d6558. Read the comment docs.

README.md Outdated
@@ -155,6 +155,10 @@ new features and changes.
* [Mailing List](https://groups.google.com/forum/#!forum/kubernetes-sig-cli)
* [Kubernetes Community site](http://kubernetes.io/community/)

### Contribution

Interested in contributing to Krew? Please refer to our [Contributing Guidelines](https://github.com/kubernetes-sigs/krew/blob/master/CONTRIBUTING.md) for more details

This comment has been minimized.

Copy link
@ahmetb

ahmetb Jun 5, 2019

Contributor

can you please follow the link convention at ## Documentation section above,
also can you please do 80-character line wraps?

This comment has been minimized.

Copy link
@hpandeycodeit

hpandeycodeit Jun 5, 2019

Author Contributor

I have changed it as per the link convention

This comment has been minimized.

Copy link
@ahmetb

ahmetb Jun 5, 2019

Contributor

looks like you missed the 80-character line wrap part :)

This comment has been minimized.

Copy link
@hpandeycodeit

hpandeycodeit Jun 5, 2019

Author Contributor

somehow it didn't reflect in the changes. I have wrapped it now. :)

Show resolved Hide resolved README.md Outdated
@ahmetb

This comment has been minimized.

Copy link
Contributor

commented Jun 5, 2019

thanks for contributing!
left a few comments.
/approve

@hpandeycodeit hpandeycodeit force-pushed the hpandeycodeit:master branch from c25498a to 6fbd336 Jun 5, 2019

@corneliusweig

This comment has been minimized.

Copy link
Contributor

commented Jun 5, 2019

@hpandeycodeit Thanks for spotting this!

Rather a question than a comment: should repo links in general refer to sigs.k8s.io/krew or is github.com/kubernetes-sigs/krew fine? (I'm aware that krew-index needs to point to github for now).

@ahmetb

This comment has been minimized.

Copy link
Contributor

commented Jun 6, 2019

/lgtm
/approve

one nit: missing trailing period. :)

should repo links in general refer to sigs.k8s.io/krew or is github.com/kubernetes-sigs/krew fine?

I'm indifferent about this. Both seem to work fine although GitHub makes it clear to anyone who's about to click a link that they're going to be going to GitHub.

I also own krew.dev domain which works the same way. :)

@k8s-ci-robot

This comment has been minimized.

Copy link

commented Jun 6, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmetb, hpandeycodeit

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit da41409 into kubernetes-sigs:master Jun 6, 2019

2 of 3 checks passed

tide Not mergeable.
Details
cla/linuxfoundation hpandeycodeit authorized
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.