Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add myself as krew maintainer #216

Merged
merged 1 commit into from Jun 19, 2019

Conversation

Projects
None yet
4 participants
@soltysh
Copy link
Contributor

commented Jun 19, 2019

/assign @ahmetb

@ahmetb

This comment has been minimized.

Copy link
Contributor

commented Jun 19, 2019

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm label Jun 19, 2019

@k8s-ci-robot

This comment has been minimized.

Copy link

commented Jun 19, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmetb, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov-io

This comment has been minimized.

Copy link

commented Jun 19, 2019

Codecov Report

Merging #216 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #216   +/-   ##
=======================================
  Coverage   54.35%   54.35%           
=======================================
  Files          13       13           
  Lines         701      701           
=======================================
  Hits          381      381           
  Misses        269      269           
  Partials       51       51

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8f3656f...2e60ac4. Read the comment docs.

@k8s-ci-robot k8s-ci-robot merged commit d6629aa into kubernetes-sigs:master Jun 19, 2019

2 of 3 checks passed

tide Not mergeable. Needs approved label.
Details
cla/linuxfoundation soltysh authorized
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@soltysh soltysh deleted the soltysh:soltysh_owners branch Jun 19, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.