Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Put local imports in a separate import group #222

Merged
merged 6 commits into from Jun 25, 2019

Conversation

Projects
None yet
4 participants
@corneliusweig
Copy link
Contributor

commented Jun 25, 2019

As pointed out by @ahmetb here #195 (comment), imports are not sorted correctly. This PR applies standard sort order so that local imports are separated in their own import group. In addition, it also configures the linters to fail if imports are not sorted as expected.

@codecov-io

This comment has been minimized.

Copy link

commented Jun 25, 2019

Codecov Report

Merging #222 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #222   +/-   ##
=======================================
  Coverage   54.35%   54.35%           
=======================================
  Files          13       13           
  Lines         701      701           
=======================================
  Hits          381      381           
  Misses        269      269           
  Partials       51       51
Impacted Files Coverage Δ
pkg/installation/install.go 36.36% <ø> (ø) ⬆️
pkg/index/indexscanner/scanner.go 67.34% <ø> (ø) ⬆️
pkg/index/validate.go 94.44% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d6629aa...7d974e0. Read the comment docs.

@ahmetb

This comment has been minimized.

Copy link
Contributor

commented Jun 25, 2019

/lgtm
/approve

@k8s-ci-robot

This comment has been minimized.

Copy link

commented Jun 25, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmetb, corneliusweig

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit cc140f1 into kubernetes-sigs:master Jun 25, 2019

2 of 3 checks passed

tide Not mergeable.
Details
cla/linuxfoundation corneliusweig authorized
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@corneliusweig corneliusweig deleted the corneliusweig:w/fix-goimports branch Jun 25, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.