Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a broken link on README.md #230

Merged
merged 1 commit into from Jun 29, 2019

Conversation

Projects
None yet
4 participants
@superbrothers
Copy link
Contributor

commented Jun 29, 2019

This PR fixes a broken link on README.md. ./issues actually links to https://github.com/kubernetes-sigs/krew/blob/master/issues, but it is non-existent page.

@codecov-io

This comment has been minimized.

Copy link

commented Jun 29, 2019

Codecov Report

Merging #230 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #230   +/-   ##
=======================================
  Coverage   53.78%   53.78%           
=======================================
  Files          14       14           
  Lines         701      701           
=======================================
  Hits          377      377           
  Misses        273      273           
  Partials       51       51

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4e47fbc...12d201d. Read the comment docs.

@ahmetb

This comment has been minimized.

Copy link
Contributor

commented Jun 29, 2019

/lgtm
/approve

@k8s-ci-robot

This comment has been minimized.

Copy link

commented Jun 29, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmetb, superbrothers

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 82a267d into kubernetes-sigs:master Jun 29, 2019

2 of 3 checks passed

tide Not mergeable.
Details
cla/linuxfoundation superbrothers authorized
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@superbrothers superbrothers deleted the superbrothers:fix-broken-link branch Jul 1, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.