Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to go modules (vgo) #235

Merged
merged 1 commit into from Jul 2, 2019

Conversation

Projects
None yet
4 participants
@ahmetb
Copy link
Contributor

commented Jul 2, 2019

Fixes #234.
/assign @corneliusweig

@k8s-ci-robot k8s-ci-robot requested review from krousey and thockin Jul 2, 2019

@ahmetb ahmetb requested review from corneliusweig and removed request for krousey and thockin Jul 2, 2019

@codecov-io

This comment has been minimized.

Copy link

commented Jul 2, 2019

Codecov Report

Merging #235 into master will increase coverage by 0.17%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #235      +/-   ##
==========================================
+ Coverage    53.6%   53.78%   +0.17%     
==========================================
  Files          16       14       -2     
  Lines         735      701      -34     
==========================================
- Hits          394      377      -17     
+ Misses        289      273      -16     
+ Partials       52       51       -1
Impacted Files Coverage Δ
pkg/environment/environment.go 77.27% <0%> (-1.9%) ⬇️
pkg/installation/upgrade.go 0% <0%> (ø) ⬆️
pkg/receipt/receipt.go
pkg/info/info.go
pkg/installation/install.go 36.36% <0%> (+4.36%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bd48083...6f1978c. Read the comment docs.

@ahmetb ahmetb force-pushed the ahmetb:vgo branch 2 times, most recently from 6ed7b96 to 7a3983e Jul 2, 2019

@corneliusweig

This comment has been minimized.

Copy link
Contributor

commented Jul 2, 2019

This PR is too big, I can't add inline comments 😆

  • .travis.yml/GOPROXY: I can't find that in the travis guide for building go projects (https://docs.travis-ci.com/user/languages/go/). Why do you set that here?
  • PR #195 added github.com/google/go-cmp v0.3.0. That's what causes the conflicts.
  • The gox install hack really looks nasty, as it is even inlined in .travis.yml. If you don't see the chance we can get rid of that soonish, I'd prefer a proper script there.
Move to go modules (vgo)
Signed-off-by: Ahmet Alp Balkan <ahmetb@google.com>
@ahmetb

This comment has been minimized.

Copy link
Contributor Author

commented Jul 2, 2019

Anytime you fetch go modules, using GOPPROXY is much faster. See http://proxy.golang.org/. This speeds up the test suite. e.g.

time go mod download => 27s
go clean -modcache -cache
time env GOPROXY=https://proxy.golang.org go mod download => 4s.

That's what causes the conflicts.

Addressed merge conflicts.

  • The gox install hack really looks nasty, as it is even inlined in .travis.yml. If you don't see the chance we can get rid of that soonish, I'd prefer a proper script there.

Solved this by introducing a hack/install-gox.sh.

@ahmetb ahmetb force-pushed the ahmetb:vgo branch from 7a3983e to 6f1978c Jul 2, 2019

@corneliusweig

This comment has been minimized.

Copy link
Contributor

commented Jul 2, 2019

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm label Jul 2, 2019

@k8s-ci-robot

This comment has been minimized.

Copy link

commented Jul 2, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmetb, corneliusweig

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [ahmetb,corneliusweig]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 16fbd25 into kubernetes-sigs:master Jul 2, 2019

2 of 3 checks passed

tide Not mergeable. Needs lgtm label.
Details
cla/linuxfoundation ahmetb authorized
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.