Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure that go modules are enabled in all helper scripts #243

Merged

Conversation

Projects
None yet
4 participants
@corneliusweig
Copy link
Contributor

commented Jul 3, 2019

Before, these scripts failed on my system when run individually.

corneliusweig added some commits Jul 3, 2019

Ensure that go modules are enabled in all helper scripts
This ensures that they can be run individually.
@codecov-io

This comment has been minimized.

Copy link

commented Jul 3, 2019

Codecov Report

Merging #243 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #243   +/-   ##
======================================
  Coverage    53.6%   53.6%           
======================================
  Files          16      16           
  Lines         735     735           
======================================
  Hits          394     394           
  Misses        289     289           
  Partials       52      52

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d043a2e...ab58456. Read the comment docs.

Show resolved Hide resolved hack/run-lint.sh Outdated

@k8s-ci-robot k8s-ci-robot added size/S and removed size/XS labels Jul 3, 2019

@@ -47,4 +47,4 @@ fi
KREW_BINARY="${krew_binary_realpath}"
export KREW_BINARY

go test -test.v sigs.k8s.io/krew/integration_test
GO111MODULE=on go test -test.v sigs.k8s.io/krew/integration_test

This comment has been minimized.

Copy link
@ahmetb

ahmetb Jul 5, 2019

Contributor

I’d use “env A=B cmd” but in this case it makes no difference.

@ahmetb

This comment has been minimized.

Copy link
Contributor

commented Jul 5, 2019

/lgtm
/approve

@k8s-ci-robot

This comment has been minimized.

Copy link

commented Jul 5, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmetb, corneliusweig

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [ahmetb,corneliusweig]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 3951c05 into kubernetes-sigs:master Jul 5, 2019

2 of 3 checks passed

tide Not mergeable. Needs lgtm label.
Details
cla/linuxfoundation corneliusweig authorized
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@corneliusweig corneliusweig deleted the corneliusweig:w/gomodules-in-scripts branch Jul 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.