Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in the developer docs for plugin manifest #251

Merged
merged 1 commit into from Jul 11, 2019

Conversation

Projects
None yet
4 participants
@itaysk
Copy link
Contributor

commented Jul 11, 2019

url should be uri

fix sample
url should be uri
@k8s-ci-robot

This comment has been minimized.

Copy link

commented Jul 11, 2019

Welcome @itaysk!

It looks like this is your first PR to kubernetes-sigs/krew 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/krew has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@codecov-io

This comment has been minimized.

Copy link

commented Jul 11, 2019

Codecov Report

Merging #251 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #251   +/-   ##
======================================
  Coverage    53.6%   53.6%           
======================================
  Files          16      16           
  Lines         735     735           
======================================
  Hits          394     394           
  Misses        289     289           
  Partials       52      52

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b2c944...435aa61. Read the comment docs.

@corneliusweig

This comment has been minimized.

Copy link
Contributor

commented Jul 11, 2019

/retitle Fix typo in the developer docs for plugin manifest

@k8s-ci-robot k8s-ci-robot changed the title fix sample Fix typo in the developer docs for plugin manifest Jul 11, 2019

@corneliusweig

This comment has been minimized.

Copy link
Contributor

commented Jul 11, 2019

/lgtm
Thanks for fixing this!

@corneliusweig

This comment has been minimized.

Copy link
Contributor

commented Jul 11, 2019

/approve

@k8s-ci-robot

This comment has been minimized.

Copy link

commented Jul 11, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: corneliusweig, itaysk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 328fc71 into kubernetes-sigs:master Jul 11, 2019

2 of 3 checks passed

tide Not mergeable.
Details
cla/linuxfoundation itaysk authorized
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.