Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: remove -v from tests #285

Merged
merged 1 commit into from Jul 22, 2019

Conversation

@ahmetb
Copy link
Member

commented Jul 21, 2019

-v is only useful if you want to see all the test cases that are being run.
I don't think this is useful locally or in the build system. I've been having
trouble scrolling a lot and trying to find the FAIL: line.

Any failed test will still print its t.Log or stdout/stderr printing along with
the test method name, so this should be fine.

/assign @corneliusweig
/kind cleanup

test: remove -v from tests
-v is only useful if you want to see all the test cases that are being run.
I don't think this is useful locally or in the build system. I've been having
trouble scrolling a lot and trying to find the FAIL: line.

Any failed test will still print its t.Log or stdout/stderr printing along with
the test method name, so this should be fine.

Signed-off-by: Ahmet Alp Balkan <ahmetb@google.com>
@codecov-io

This comment has been minimized.

Copy link

commented Jul 21, 2019

Codecov Report

Merging #285 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #285   +/-   ##
=======================================
  Coverage   54.84%   54.84%           
=======================================
  Files          19       19           
  Lines         877      877           
=======================================
  Hits          481      481           
  Misses        342      342           
  Partials       54       54

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2364ae4...22dbbe0. Read the comment docs.

@corneliusweig

This comment has been minimized.

Copy link
Contributor

commented Jul 22, 2019

Yeah, makes sense.
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm label Jul 22, 2019

@k8s-ci-robot

This comment has been minimized.

Copy link

commented Jul 22, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmetb, corneliusweig

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [ahmetb,corneliusweig]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 7f6b8c8 into kubernetes-sigs:master Jul 22, 2019

2 of 3 checks passed

tide Not mergeable. Needs lgtm label.
Details
cla/linuxfoundation ahmetb authorized
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.