Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate plugins can be removed without local manifest #300

Merged
merged 3 commits into from Jul 31, 2019

Conversation

@ahmetb
Copy link
Member

commented Jul 31, 2019

This validates the scenario that we can remove/rename plugins in the index
without breaking local user installations (since this is now possible with
the install receipts).

/assign @corneliusweig

Validate plugins can be removed without local manifest
This validates the scenario that we can remove/rename plugins in the index
without breaking local user installations (since this is now possible with
the install receipts).

Signed-off-by: Ahmet Alp Balkan <ahmetb@google.com>
@codecov-io

This comment has been minimized.

Copy link

commented Jul 31, 2019

Codecov Report

Merging #300 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #300   +/-   ##
=======================================
  Coverage   55.66%   55.66%           
=======================================
  Files          19       19           
  Lines         918      918           
=======================================
  Hits          511      511           
  Misses        355      355           
  Partials       52       52

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 38672e5...6be6866. Read the comment docs.

@corneliusweig
Copy link
Contributor

left a comment

Good idea to add this test-case.

integration_test/uninstall_test.go Outdated Show resolved Hide resolved
integration_test/uninstall_test.go Outdated Show resolved Hide resolved
integration_test/uninstall_test.go Outdated Show resolved Hide resolved
defer cleanup()

test = test.WithIndex()
localManifest := filepath.Join(test.Root(), "index", "plugins", validPlugin+constants.ManifestExtension)

This comment has been minimized.

Copy link
@corneliusweig

corneliusweig Jul 31, 2019

Contributor

I'm a bit unhappy that we depend on the implementation detail of where the manifest is stored. It would be cleaner to use environment.Paths here. Maybe it's time to refactor the environment package, so that it can be used without setting up env variables.

This comment has been minimized.

Copy link
@ahmetb

ahmetb Jul 31, 2019

Author Member

Honestly I agree, but we'd immediately know when we change the paths because the test would start breaking.

This comment has been minimized.

Copy link
@ahmetb

ahmetb Jul 31, 2019

Author Member

That said I think we can expose NewPaths() here that doesn't rely on environment variables, for testing or other purposes:

image

This comment has been minimized.

Copy link
@corneliusweig

corneliusweig Jul 31, 2019

Contributor

Ok, let's do that in another PR and close this one. I think there are more locations which can be made simpler.

ahmetb added some commits Jul 31, 2019

address comments
Signed-off-by: Ahmet Alp Balkan <ahmetb@google.com>
address comments
Signed-off-by: Ahmet Alp Balkan <ahmetb@google.com>
@corneliusweig

This comment has been minimized.

Copy link
Contributor

commented Jul 31, 2019

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm label Jul 31, 2019

@k8s-ci-robot

This comment has been minimized.

Copy link

commented Jul 31, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmetb, corneliusweig

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [ahmetb,corneliusweig]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 8d148b5 into kubernetes-sigs:master Jul 31, 2019

2 of 3 checks passed

tide Not mergeable. Needs lgtm label.
Details
cla/linuxfoundation ahmetb authorized
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.