Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md for krew v0.3.0 #333

Merged

Conversation

@corneliusweig
Copy link
Contributor

commented Sep 6, 2019

This PR is a workaround for the failed push to master, see #324 (comment)

@codecov-io

This comment has been minimized.

Copy link

commented Sep 6, 2019

Codecov Report

Merging #333 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #333   +/-   ##
=======================================
  Coverage   56.78%   56.78%           
=======================================
  Files          19       19           
  Lines         907      907           
=======================================
  Hits          515      515           
  Misses        339      339           
  Partials       53       53

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 73ee7e2...28594b2. Read the comment docs.

@k8s-ci-robot k8s-ci-robot requested review from ahmetb and soltysh Sep 6, 2019

@k8s-ci-robot k8s-ci-robot added the size/XS label Sep 6, 2019

@corneliusweig

This comment has been minimized.

Copy link
Contributor Author

commented Sep 6, 2019

/hold
As the release is not completed.

@ahmetb

This comment has been minimized.

Copy link
Member

commented Sep 10, 2019

@corneliusweig can you update the binary URLs in README.md + rebase?
Then we can merge this and tag it as v0.3.0 (manually) then push.

@ahmetb

This comment has been minimized.

Copy link
Member

commented Sep 10, 2019

I also suspect that we need to update our RELEASING.md to point out that the commit must be approved first to make a stable release with it?

Curious how other similar Kubernetes projects are doing it.

@corneliusweig corneliusweig force-pushed the corneliusweig:w/bump-krew-version branch from 67be146 to 28594b2 Sep 10, 2019

@corneliusweig

This comment has been minimized.

Copy link
Contributor Author

commented Sep 10, 2019

/hold cancel

@ahmetb

This comment has been minimized.

Copy link
Member

commented Sep 10, 2019

/lgtm
/approve
💣 Fire in the hole! 🌩

@k8s-ci-robot

This comment has been minimized.

Copy link

commented Sep 10, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmetb, corneliusweig

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [ahmetb,corneliusweig]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 9463c6c into kubernetes-sigs:master Sep 10, 2019

2 of 3 checks passed

tide Not mergeable. Needs lgtm label.
Details
cla/linuxfoundation corneliusweig authorized
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.