Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set up Travis CI for release binaries #334

Merged
merged 2 commits into from Sep 10, 2019

Conversation

@ahmetb
Copy link
Member

commented Sep 8, 2019

Ref: #324.
Ref: #333.

Fixes #337.
/assign @corneliusweig

@codecov-io

This comment has been minimized.

Copy link

commented Sep 8, 2019

Codecov Report

Merging #334 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #334   +/-   ##
=======================================
  Coverage   56.89%   56.89%           
=======================================
  Files          19       19           
  Lines         907      907           
=======================================
  Hits          516      516           
  Misses        338      338           
  Partials       53       53

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9f1175a...d247900. Read the comment docs.

@corneliusweig

This comment has been minimized.

Copy link
Contributor

commented Sep 8, 2019

As far as I can tell, this looks good. I only have little experience with releasing via travis on Github, though. Can we somehow test this before merging?

One minor nit: Before, we were building with golang:alpine-1, which uses golang 1.13 (see https://github.com/docker-library/golang/blob/2909cfd3ecb769671eb8222eaf9a782a6aed024d/1.13/alpine3.10/Dockerfile). On Travis, we are still using golang 1.11. Can we bump that for our travis builds?

@corneliusweig

This comment has been minimized.

Copy link
Contributor

commented Sep 8, 2019

PS: It would make sense to also adapt hack/make-release-notes.sh with the new download URLs for the krew artifacts.

@ahmetb ahmetb force-pushed the ahmetb:travis-release-binary branch from 04165f6 to 1f53fb1 Sep 8, 2019

@ahmetb

This comment has been minimized.

Copy link
Member Author

commented Sep 9, 2019

I've tagged a v0.3.0-rc.1 with this commit. I've manually marked it as pre-release.
Sadly, there's still no clean way to auto-populate release message (#122) but it works.

@ahmetb ahmetb force-pushed the ahmetb:travis-release-binary branch from 1f53fb1 to 77c224f Sep 9, 2019

@ahmetb

This comment has been minimized.

Copy link
Member Author

commented Sep 9, 2019

Addressed comments.

@ahmetb

This comment has been minimized.

Copy link
Member Author

commented Sep 9, 2019

I'm getting some weird errors after switching go: 1.13.x, might go back to 1.11.x.

image

@ahmetb ahmetb force-pushed the ahmetb:travis-release-binary branch from 77c224f to eaa9900 Sep 9, 2019

@ahmetb ahmetb force-pushed the ahmetb:travis-release-binary branch from eaa9900 to 8f8ed08 Sep 10, 2019

Set up Travis CI for release binaries
Signed-off-by: Ahmet Alp Balkan <ahmetb@google.com>
move flag.Parse() to main
Signed-off-by: Ahmet Alp Balkan <ahmetb@google.com>
@corneliusweig

This comment has been minimized.

Copy link
Contributor

commented Sep 10, 2019

/lgtm
/approve
Big 👍 for getting the migration to Travis done so quickly AND fixing this strange flags.Parse() bug.

@k8s-ci-robot k8s-ci-robot added the lgtm label Sep 10, 2019

@k8s-ci-robot

This comment has been minimized.

Copy link

commented Sep 10, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmetb, corneliusweig

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [ahmetb,corneliusweig]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 73ee7e2 into kubernetes-sigs:master Sep 10, 2019

2 of 3 checks passed

tide Not mergeable. Needs lgtm label.
Details
cla/linuxfoundation ahmetb authorized
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@ahmetb ahmetb referenced this pull request Sep 10, 2019
@corneliusweig

This comment has been minimized.

Copy link
Contributor

commented Sep 10, 2019

Btw, with github releases we can get the number of downloads pretty easily:

curl -sLH 'Accept: application/vnd.github.v3+json' "https://api.github.com/repos/kubernetes-sigs/krew/releases" | \
        jq 'map([{key: "release", value: .tag_name}, {key: "assets", value: ( .assets | map({key: .name, value: .download_count}) | from_entries )}]|from_entries) '

At least we will know how many users upgraded krew :)

@ahmetb

This comment has been minimized.

Copy link
Member Author

commented Sep 10, 2019

Exactly my thoughts.

I wish we had an app that monitored that endpoint it over time so we could tell the delta by {day, month, year} to do some analytics.

I have developed https://gh-downloads-dpyb4duzqq-uc.a.run.app/grpc-ecosystem/grpc-health-probe many months ago but it doesn't have any sort of persistent storage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.