Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lint: bump golangci-lint to 1.18 #336

Merged
merged 1 commit into from Sep 10, 2019

Conversation

@ferhatelmas
Copy link
Contributor

commented Sep 10, 2019

bump golangci-lint to 1.18, various improvement and go 1.13

related #334

@codecov-io

This comment has been minimized.

Copy link

commented Sep 10, 2019

Codecov Report

Merging #336 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #336   +/-   ##
=======================================
  Coverage   56.89%   56.89%           
=======================================
  Files          19       19           
  Lines         907      907           
=======================================
  Hits          516      516           
  Misses        338      338           
  Partials       53       53

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d0a19e2...56d152b. Read the comment docs.

@ahmetb

This comment has been minimized.

Copy link
Member

commented Sep 10, 2019

Is this bump specifically addressing the issue we're seeing at #334?

@ahmetb

This comment has been minimized.

Copy link
Member

commented Sep 10, 2019

Just saw your note, let's take it in, and I'll rebase #334.
/lgtm
/approve

@k8s-ci-robot

This comment has been minimized.

Copy link

commented Sep 10, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmetb, ferhatelmas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 9f1175a into kubernetes-sigs:master Sep 10, 2019
2 of 3 checks passed
2 of 3 checks passed
tide Not mergeable.
Details
cla/linuxfoundation ferhatelmas authorized
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@ahmetb

This comment has been minimized.

Copy link
Member

commented Sep 10, 2019

Thanks, it seems like it has helped unblock switching to go1.13 in #334.

@ferhatelmas

This comment has been minimized.

Copy link
Contributor Author

commented Sep 10, 2019

glad to see it helped 😺

@ferhatelmas ferhatelmas deleted the ferhatelmas:lint-bump branch Sep 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.