Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove krew.zip from release, add krew.exe #339

Merged
merged 1 commit into from Sep 11, 2019

Conversation

@ahmetb
Copy link
Member

commented Sep 11, 2019

This patch removes krew.zip (previously used in krew.yaml as well as
windows installation instructions) and adds:

  • krew.exe (to be used in first-time installation on windows)
  • krew.exe.sha256 (checksum file)

ref: #338
/hold

This patch removes krew.zip (previously used in krew.yaml as well as
windows installation instructions) and adds:

- krew.exe (to be used in first-time installation on windows)
- krew.exe.sha256 (checksum file)

Signed-off-by: Ahmet Alp Balkan <ahmetb@google.com>
@codecov-io

This comment has been minimized.

Copy link

commented Sep 11, 2019

Codecov Report

Merging #339 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #339   +/-   ##
=======================================
  Coverage   56.78%   56.78%           
=======================================
  Files          19       19           
  Lines         907      907           
=======================================
  Hits          515      515           
  Misses        339      339           
  Partials       53       53

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9463c6c...24a1a41. Read the comment docs.

@corneliusweig

This comment has been minimized.

Copy link
Contributor

commented Sep 11, 2019

/lgtm
/approve
Maybe it's worth thinking about releasing the exe file zipped. Brings a 12MB binary down to 4.something.

@k8s-ci-robot

This comment has been minimized.

Copy link

commented Sep 11, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmetb, corneliusweig

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [ahmetb,corneliusweig]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ahmetb

This comment has been minimized.

Copy link
Member Author

commented Sep 11, 2019

Maybe it's worth thinking about releasing the exe file zipped. Brings a 12MB binary down to 4.something.

I'm not too worried since it's just 1-time. Users will be downloading the .tar.gz anyway.

/hold cancel

@k8s-ci-robot k8s-ci-robot merged commit 0837beb into kubernetes-sigs:master Sep 11, 2019
2 of 3 checks passed
2 of 3 checks passed
tide Not mergeable. Should not have do-not-merge/hold label.
Details
cla/linuxfoundation ahmetb authorized
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@ahmetb ahmetb referenced this pull request Sep 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.