Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to golangci-lint v0.19.0 #346

Merged
merged 1 commit into from Sep 24, 2019

Conversation

@corneliusweig
Copy link
Contributor

commented Sep 23, 2019

..and fix one new issue

Release notes for linter: https://github.com/golangci/golangci-lint/releases/tag/v1.19.0

..and fix one new issue
@ahmetb

This comment has been minimized.

Copy link
Member

commented Sep 24, 2019

/lgtm
/approve

@k8s-ci-robot

This comment has been minimized.

Copy link

commented Sep 24, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmetb, corneliusweig

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [ahmetb,corneliusweig]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 0aff0ff into kubernetes-sigs:master Sep 24, 2019
2 of 3 checks passed
2 of 3 checks passed
tide Not mergeable. Needs lgtm label.
Details
cla/linuxfoundation corneliusweig authorized
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.