Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update release instructions #348

Conversation

@corneliusweig
Copy link
Contributor

commented Sep 24, 2019

This was necessary after permission changes due to the
repository migration to kubernetes-sigs.

/cc @ahmetb

This was necessary after permission changes due to the
repository migration to kubernetes-sigs.
@codecov-io

This comment has been minimized.

Copy link

commented Sep 24, 2019

Codecov Report

Merging #348 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #348   +/-   ##
=======================================
  Coverage   56.78%   56.78%           
=======================================
  Files          19       19           
  Lines         907      907           
=======================================
  Hits          515      515           
  Misses        339      339           
  Partials       53       53

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c241a35...87f80ee. Read the comment docs.


1. **Tag the release:**

```sh
git reset --hard origin/master # when the previous merge is done

This comment has been minimized.

Copy link
@ahmetb

ahmetb Sep 25, 2019

Member

this requires a

git fetch origin

because after the bot/human merges the commit, the commit number might be different. So it needs to be fetched again from upstream.

This comment has been minimized.

Copy link
@corneliusweig

corneliusweig Sep 25, 2019

Author Contributor

Yes, better be totally explicit here 👍

@ahmetb

This comment has been minimized.

Copy link
Member

commented Sep 25, 2019

Also, it would be worthwhile adding a section about updating the CI bits on krew-index repo. It seems like it is easily forgotten.

@ahmetb

This comment has been minimized.

Copy link
Member

commented Sep 25, 2019

/lgtm
/approve
Are you going to address the CI updates i mentioned later?
/hold

@k8s-ci-robot

This comment has been minimized.

Copy link

commented Sep 25, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmetb, corneliusweig

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [ahmetb,corneliusweig]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot removed the lgtm label Sep 25, 2019
@corneliusweig

This comment has been minimized.

Copy link
Contributor Author

commented Sep 25, 2019

@ahmetb Sorry, I totally forgot about that! Thanks for being so thorough!
/hold cancel

@ahmetb

This comment has been minimized.

Copy link
Member

commented Sep 25, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label Sep 25, 2019
@k8s-ci-robot k8s-ci-robot merged commit 9c0cfcd into kubernetes-sigs:master Sep 25, 2019
2 of 3 checks passed
2 of 3 checks passed
tide Not mergeable. Needs lgtm label.
Details
cla/linuxfoundation corneliusweig authorized
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.