Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade golangci-lint to v1.20.0 #351

Merged

Conversation

@corneliusweig
Copy link
Contributor

commented Oct 8, 2019

No description provided.

@ferhatelmas

This comment has been minimized.

Copy link
Contributor

commented Oct 8, 2019

/lgtm

@k8s-ci-robot

This comment has been minimized.

Copy link

commented Oct 8, 2019

@ferhatelmas: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Contributor

left a comment

LGTM 😉

@ahmetb

This comment has been minimized.

Copy link
Member

commented Oct 9, 2019

/lgtm
/approve

@k8s-ci-robot

This comment has been minimized.

Copy link

commented Oct 9, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmetb, corneliusweig

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [ahmetb,corneliusweig]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 60c18e1 into kubernetes-sigs:master Oct 9, 2019
2 of 3 checks passed
2 of 3 checks passed
tide Not mergeable. Needs lgtm label.
Details
cla/linuxfoundation corneliusweig authorized
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@corneliusweig corneliusweig deleted the corneliusweig:w/upgrade-linter branch Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.