Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added condition for generating KUDO github stars #363

Merged
merged 2 commits into from Nov 1, 2019

Conversation

@runyontr
Copy link
Contributor

runyontr commented Nov 1, 2019

Proper solution to kubernetes-sigs/krew-index#296

/assign @corneliusweig

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Nov 1, 2019

Codecov Report

Merging #363 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #363   +/-   ##
=======================================
  Coverage   56.73%   56.73%           
=======================================
  Files          19       19           
  Lines         906      906           
=======================================
  Hits          514      514           
  Misses        339      339           
  Partials       53       53

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ceb95d9...b4c87bb. Read the comment docs.

@ahmetb

This comment has been minimized.

Copy link
Member

ahmetb commented Nov 1, 2019

/lgtm
/approve

@k8s-ci-robot

This comment has been minimized.

Copy link

k8s-ci-robot commented Nov 1, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmetb, runyontr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 87cf308 into kubernetes-sigs:master Nov 1, 2019
2 of 3 checks passed
2 of 3 checks passed
tide Not mergeable. Needs approved, lgtm labels.
Details
cla/linuxfoundation runyontr authorized
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@runyontr runyontr deleted the runyontr:kudo-plugin-stars branch Nov 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.