Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump min go to v1.13 in go.mod #395

Merged
merged 1 commit into from Nov 18, 2019
Merged

Conversation

@ferhatelmas
Copy link
Contributor

ferhatelmas commented Nov 18, 2019

Since we only develop via 1.13, it's a good idea to set min go to 1.13 to give a better error message if this is the issue.

@erain
erain approved these changes Nov 18, 2019
Copy link

erain left a comment

lgtm

@corneliusweig

This comment has been minimized.

Copy link
Contributor

corneliusweig commented Nov 18, 2019

/lgtm
/approve

@k8s-ci-robot

This comment has been minimized.

Copy link

k8s-ci-robot commented Nov 18, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: corneliusweig, ferhatelmas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit e153115 into kubernetes-sigs:master Nov 18, 2019
2 of 3 checks passed
2 of 3 checks passed
tide Not mergeable. Needs approved, lgtm labels.
Details
cla/linuxfoundation ferhatelmas authorized
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Nov 18, 2019

Codecov Report

Merging #395 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #395   +/-   ##
=======================================
  Coverage   56.64%   56.64%           
=======================================
  Files          19       19           
  Lines         918      918           
=======================================
  Hits          520      520           
  Misses        346      346           
  Partials       52       52

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 28fbf81...13fb542. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.