Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop GO111MODULE env variable #396

Merged
merged 2 commits into from Nov 26, 2019
Merged

Conversation

@ferhatelmas
Copy link
Contributor

ferhatelmas commented Nov 18, 2019

Drop obsolete GO111MODULE environment variable.

Also, dry tool installation a bit.

fixes #388.

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Nov 18, 2019

Codecov Report

Merging #396 into master will decrease coverage by 0.12%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #396      +/-   ##
==========================================
- Coverage   56.64%   56.52%   -0.13%     
==========================================
  Files          19       19              
  Lines         918      920       +2     
==========================================
  Hits          520      520              
- Misses        346      347       +1     
- Partials       52       53       +1
Impacted Files Coverage Δ
pkg/index/validation/validate.go 92.1% <0%> (-2.49%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e153115...05d267a. Read the comment docs.

@ferhatelmas ferhatelmas force-pushed the ferhatelmas:drop-go111 branch from a65260f to 002ab05 Nov 18, 2019
@k8s-ci-robot k8s-ci-robot added size/L and removed size/M labels Nov 18, 2019
@ferhatelmas

This comment has been minimized.

Copy link
Contributor Author

ferhatelmas commented Nov 18, 2019

Generally, tools(golangci-lint, impi, etc.) are installed under global GOBIN but release-notes is installed under hack.

How about installing it similar to others or others similar to release notes for consistency?

@ferhatelmas ferhatelmas force-pushed the ferhatelmas:drop-go111 branch from 002ab05 to a2e5fec Nov 18, 2019
hack/install-gox.sh Outdated Show resolved Hide resolved
@ferhatelmas ferhatelmas force-pushed the ferhatelmas:drop-go111 branch from a2e5fec to 6f796e1 Nov 18, 2019
@corneliusweig

This comment has been minimized.

Copy link
Contributor

corneliusweig commented Nov 18, 2019

@ferhatelmas thanks for doing this. Could you split this PR in two separate ones? One for the GO111MODULE change and one only for the dry improvements?

@ferhatelmas ferhatelmas force-pushed the ferhatelmas:drop-go111 branch from 6f796e1 to 4ce30f3 Nov 18, 2019
@k8s-ci-robot k8s-ci-robot added size/M and removed size/L labels Nov 18, 2019
@ferhatelmas ferhatelmas force-pushed the ferhatelmas:drop-go111 branch from 4ce30f3 to 9fdbec9 Nov 18, 2019
@ahmetb

This comment has been minimized.

Copy link
Member

ahmetb commented Nov 25, 2019

I think this is good now.
There was a time when if you explicitly didn't enable go.mod, it wouldn't use it on Travis. Looks like they’ve improved things since go1.11. :)

@corneliusweig

This comment has been minimized.

Copy link
Contributor

corneliusweig commented Nov 26, 2019

Generally, tools(golangci-lint, impi, etc.) are installed under global GOBIN but release-notes is installed under hack.

I think we can move release-notes out of the hack folder. I didn't want to clutter the system, but 🤷‍♂ .

/lgtm
/approve

@k8s-ci-robot

This comment has been minimized.

Copy link

k8s-ci-robot commented Nov 26, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: corneliusweig, ferhatelmas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 482d451 into kubernetes-sigs:master Nov 26, 2019
2 of 3 checks passed
2 of 3 checks passed
tide Not mergeable. Needs approved label.
Details
cla/linuxfoundation ferhatelmas authorized
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.