Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update post installation text #408

Merged

Conversation

@chriskim06
Copy link
Contributor

chriskim06 commented Nov 29, 2019

Changes for #402

Repurpose prepCaveats to just add the indentation formatting
@k8s-ci-robot

This comment has been minimized.

Copy link

k8s-ci-robot commented Nov 29, 2019

Welcome @chriskim06!

It looks like this is your first PR to kubernetes-sigs/krew 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/krew has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/S label Nov 29, 2019
@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Nov 29, 2019

Codecov Report

Merging #408 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #408   +/-   ##
=======================================
  Coverage   56.52%   56.52%           
=======================================
  Files          19       19           
  Lines         920      920           
=======================================
  Hits          520      520           
  Misses        347      347           
  Partials       53       53

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fb7de16...b5c6604. Read the comment docs.

@chriskim06

This comment has been minimized.

Copy link
Contributor Author

chriskim06 commented Nov 29, 2019

/assign @ahmetb

@ahmetb

This comment has been minimized.

Copy link
Member

ahmetb commented Nov 30, 2019

Looking good. Thanks for contributing @chriskim06. 👍
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm label Nov 30, 2019
@k8s-ci-robot

This comment has been minimized.

Copy link

k8s-ci-robot commented Nov 30, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmetb, chriskim06

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 9d1085f into kubernetes-sigs:master Nov 30, 2019
2 of 3 checks passed
2 of 3 checks passed
tide Not mergeable. Needs approved, lgtm labels.
Details
cla/linuxfoundation chriskim06 authorized
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.