Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move implementation details to internal #422

Merged
merged 1 commit into from Dec 4, 2019

Conversation

@ferhatelmas
Copy link
Contributor

ferhatelmas commented Dec 3, 2019

move all packages into internal except pkg/index and pkg/constants.

fixes #291

@ahmetb

This comment has been minimized.

Copy link
Member

ahmetb commented Dec 3, 2019

HUGE if we can get it in ASAP before it starts introducing merge conflicts everywhere :)

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Dec 3, 2019

Codecov Report

Merging #422 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #422   +/-   ##
=======================================
  Coverage   56.41%   56.41%           
=======================================
  Files          19       19           
  Lines         927      927           
=======================================
  Hits          523      523           
  Misses        349      349           
  Partials       55       55
Impacted Files Coverage Δ
internal/download/verifier.go 100% <ø> (ø)
internal/installation/install.go 42.42% <ø> (ø)
internal/installation/upgrade.go 0% <ø> (ø)
internal/receiptsmigration/migration.go 46.15% <ø> (ø)
cmd/validate-krew-manifest/main.go 54.54% <ø> (ø) ⬆️
internal/pathutil/pathutil.go 100% <ø> (ø)
internal/index/validation/validate.go 92.1% <ø> (ø)
internal/installation/move.go 33.09% <ø> (ø)
internal/installation/platform.go 79.16% <ø> (ø)
internal/version/version.go 100% <ø> (ø)
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 26e7328...bf6e29d. Read the comment docs.

@ahmetb

This comment has been minimized.

Copy link
Member

ahmetb commented Dec 4, 2019

I'll go ahead with this, seeing no issues locally.

I'll send a PR to move cmd/* commands to v0.3.3 later.

@ahmetb

This comment has been minimized.

Copy link
Member

ahmetb commented Dec 4, 2019

/lgtm
/approve

@k8s-ci-robot

This comment has been minimized.

Copy link

k8s-ci-robot commented Dec 4, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmetb, ferhatelmas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit ab1c7f7 into kubernetes-sigs:master Dec 4, 2019
2 of 3 checks passed
2 of 3 checks passed
tide Not mergeable. Needs approved, lgtm labels.
Details
cla/linuxfoundation ferhatelmas authorized
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.