Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add note to publish the plugin source code #436

Merged
merged 1 commit into from Dec 13, 2019

Conversation

@corneliusweig
Copy link
Contributor

corneliusweig commented Dec 13, 2019

Mention that plugin source code needs to be public in order to be accepted for krew-index.

Also see kubernetes-sigs/krew-index#386.

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Dec 13, 2019

Codecov Report

Merging #436 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #436   +/-   ##
=======================================
  Coverage   56.35%   56.35%           
=======================================
  Files          19       19           
  Lines         928      928           
=======================================
  Hits          523      523           
  Misses        350      350           
  Partials       55       55

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 541b48b...c7e9b68. Read the comment docs.

@ahmetb

This comment has been minimized.

Copy link
Member

ahmetb commented Dec 13, 2019

/lgtm
/approve

@k8s-ci-robot

This comment has been minimized.

Copy link

k8s-ci-robot commented Dec 13, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmetb, corneliusweig

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [ahmetb,corneliusweig]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 36c755c into kubernetes-sigs:master Dec 13, 2019
2 of 3 checks passed
2 of 3 checks passed
tide Not mergeable. Needs lgtm label.
Details
cla/linuxfoundation corneliusweig authorized
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.