Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump shfmt to v3 #452

Merged
merged 1 commit into from Jan 2, 2020
Merged

Bump shfmt to v3 #452

merged 1 commit into from Jan 2, 2020

Conversation

@ferhatelmas
Copy link
Contributor

ferhatelmas commented Jan 2, 2020

Stable module supported pure go release.

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Jan 2, 2020

Codecov Report

Merging #452 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #452   +/-   ##
=======================================
  Coverage   56.47%   56.47%           
=======================================
  Files          19       19           
  Lines         926      926           
=======================================
  Hits          523      523           
  Misses        350      350           
  Partials       53       53

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6634890...3457ea2. Read the comment docs.

@ahmetb

This comment has been minimized.

Copy link
Member

ahmetb commented Jan 2, 2020

/lgtm
/approve
Do we need to stay up to date this much? I've also commented the same thing on the last golang lint PR. :)

@k8s-ci-robot

This comment has been minimized.

Copy link

k8s-ci-robot commented Jan 2, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmetb, ferhatelmas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit f92c9d7 into kubernetes-sigs:master Jan 2, 2020
2 of 3 checks passed
2 of 3 checks passed
tide Not mergeable. Needs approved, lgtm labels.
Details
cla/linuxfoundation ferhatelmas authorized
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@ferhatelmas

This comment has been minimized.

Copy link
Contributor Author

ferhatelmas commented Jan 2, 2020

Do we need to stay up to date this much? I've also commented the same thing on the last golang lint PR. :)

Probably not but it's also a good habit.

I also saw your previous comment but did this too since it's major bump. I expected we would catch some new issues but the code is clean, nice job 😄

@ferhatelmas ferhatelmas deleted the ferhatelmas:shfmt-bump branch Jan 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.