Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix upgrade if a plugin installed from manifest #458

merged 2 commits into from Jan 9, 2020


Copy link

ferhatelmas commented Jan 4, 2020

If a plugin isn't in index, upgrade for all doesn't fail anymore.
Also, added an integration test by modifying valid plugin konfig to konfig-non-index.

Related to #454 problem 1.


This comment has been minimized.

Copy link

codecov-io commented Jan 4, 2020

Codecov Report

Merging #458 into master will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #458      +/-   ##
+ Coverage   56.47%   56.52%   +0.04%     
  Files          19       19              
  Lines         926      927       +1     
+ Hits          523      524       +1     
  Misses        350      350              
  Partials       53       53
Impacted Files Coverage Δ
cmd/validate-krew-manifest/main.go 54.54% <0%> (+0.46%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f92c9d7...a554426. Read the comment docs.

validPlugin2 = "mtail" // a plugin in central index with small size
validPlugin = "konfig" // a plugin in central index with small size
validPlugin2 = "mtail" // a plugin in central index with small size
validNonIndexPlugin = "konfig-non-index" // a plugin not in central index with small size

This comment has been minimized.

Copy link

ahmetb Jan 4, 2020


instead of doing this let's do this:

  1. test.WithIndex()
  2. find konfig.yaml in the index path, delete it
  3. use upgrade --no-update-index in both install and upgrade calls in the integration test.

this way:

  • you can fake the situation that konfig is not in the index.
  • without having to duplicate a testdata file (I really dislike increasing testdata)

This comment has been minimized.

Copy link

ferhatelmas Jan 8, 2020

Author Contributor

Sounds much better, updated.


This comment has been minimized.

Copy link

corneliusweig commented Jan 9, 2020

..and sorry for this 🐌 response


This comment has been minimized.

Copy link

k8s-ci-robot commented Jan 9, 2020


This pull-request has been approved by: corneliusweig, ferhatelmas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit d3103f3 into kubernetes-sigs:master Jan 9, 2020
2 of 3 checks passed
2 of 3 checks passed
tide Not mergeable. Needs approved, lgtm labels.
cla/linuxfoundation ferhatelmas authorized
continuous-integration/travis-ci/pr The Travis CI build passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
5 participants
You can’t perform that action at this time.