Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mention #krew slack room #495

Merged
merged 1 commit into from Feb 5, 2020

Conversation

ahmetb
Copy link
Member

@ahmetb ahmetb commented Feb 5, 2020

No description provided.

Signed-off-by: Ahmet Alp Balkan <ahmetb@google.com>
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes approved size/S labels Feb 5, 2020
@codecov-io
Copy link

@codecov-io codecov-io commented Feb 5, 2020

Codecov Report

Merging #495 into master will increase coverage by 0.52%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #495      +/-   ##
========================================
+ Coverage   56.47%    57%   +0.52%     
========================================
  Files          19     21       +2     
  Lines         926    956      +30     
========================================
+ Hits          523    545      +22     
- Misses        350    357       +7     
- Partials       53     54       +1
Impacted Files Coverage 螖
cmd/krew/cmd/internal/setup_check.go 91.66% <0%> (酶)
cmd/krew/cmd/internal/security_notice.go 0% <0%> (酶)

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 58a5184...5b090da. Read the comment docs.

@corneliusweig
Copy link
Contributor

@corneliusweig corneliusweig commented Feb 5, 2020

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm label Feb 5, 2020
@k8s-ci-robot
Copy link
Contributor

@k8s-ci-robot k8s-ci-robot commented Feb 5, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmetb, corneliusweig

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [ahmetb,corneliusweig]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 5826e5e into kubernetes-sigs:master Feb 5, 2020
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cncf-cla: yes lgtm size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants