Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mention #krew slack room #495

Merged
merged 1 commit into from Feb 5, 2020
Merged

Conversation

@ahmetb
Copy link
Member

ahmetb commented Feb 5, 2020

No description provided.

Signed-off-by: Ahmet Alp Balkan <ahmetb@google.com>
@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Feb 5, 2020

Codecov Report

Merging #495 into master will increase coverage by 0.52%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #495      +/-   ##
========================================
+ Coverage   56.47%    57%   +0.52%     
========================================
  Files          19     21       +2     
  Lines         926    956      +30     
========================================
+ Hits          523    545      +22     
- Misses        350    357       +7     
- Partials       53     54       +1
Impacted Files Coverage Δ
cmd/krew/cmd/internal/setup_check.go 91.66% <0%> (ø)
cmd/krew/cmd/internal/security_notice.go 0% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 58a5184...5b090da. Read the comment docs.

@corneliusweig

This comment has been minimized.

Copy link
Contributor

corneliusweig commented Feb 5, 2020

/lgtm
/approve

@k8s-ci-robot

This comment has been minimized.

Copy link

k8s-ci-robot commented Feb 5, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmetb, corneliusweig

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [ahmetb,corneliusweig]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 5826e5e into kubernetes-sigs:master Feb 5, 2020
3 of 4 checks passed
3 of 4 checks passed
build
Details
tide Not mergeable.
Details
cla/linuxfoundation ahmetb authorized
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.