Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix version stamping in build script #496

Merged
merged 1 commit into from Feb 6, 2020

Conversation

@ahmetb
Copy link
Member

ahmetb commented Feb 6, 2020

Fixes #...
Related issue: #...

@ahmetb

This comment has been minimized.

Copy link
Member Author

ahmetb commented Feb 6, 2020

ARGH the unit test was taking dependency on broken behavior 🤦‍♂

@corneliusweig do you think I should remove GitTag and GitCommit from the test case doing the diff test? I think we can't find out those values during testing.

@ahmetb

This comment has been minimized.

Copy link
Member Author

ahmetb commented Feb 6, 2020

cc: @tony-yang it seems like we're doing cmp.Diff here which is map equality, though it would probably be better to just make sure if the specified set of keys/values exist in the output (instead of exact match)

@ahmetb ahmetb force-pushed the ahmetb:stamping-fix branch from b1aa2bf to a3ae4ba Feb 6, 2020
@ahmetb

This comment has been minimized.

Copy link
Member Author

ahmetb commented Feb 6, 2020

/hold
until #497; then rebase.

Signed-off-by: Ahmet Alp Balkan <ahmetb@google.com>
@ahmetb

This comment has been minimized.

Copy link
Member Author

ahmetb commented Feb 6, 2020

/hold cancel

@ahmetb ahmetb force-pushed the ahmetb:stamping-fix branch from a3ae4ba to f55531e Feb 6, 2020
@corneliusweig

This comment has been minimized.

Copy link
Contributor

corneliusweig commented Feb 6, 2020

Thanks for finding this bug.
/lgtm
/approve

@k8s-ci-robot

This comment has been minimized.

Copy link

k8s-ci-robot commented Feb 6, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmetb, corneliusweig

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [ahmetb,corneliusweig]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 0c83dce into kubernetes-sigs:master Feb 6, 2020
3 of 4 checks passed
3 of 4 checks passed
build
Details
tide Not mergeable. Job continuous-integration/travis-ci/pr has not succeeded.
Details
cla/linuxfoundation ahmetb authorized
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@tony-yang

This comment has been minimized.

Copy link
Contributor

tony-yang commented Feb 7, 2020

cc: @tony-yang it seems like we're doing cmp.Diff here which is map equality, though it would probably be better to just make sure if the specified set of keys/values exist in the output (instead of exact match)

Fair point. Thanks Ahmet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.