Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add logo to docs #500

Merged
merged 1 commit into from Feb 11, 2020
Merged

Add logo to docs #500

merged 1 commit into from Feb 11, 2020

Conversation

@ahmetb
Copy link
Member

ahmetb commented Feb 9, 2020

  • add logo to readme (+repo social preview)
  • create a doc listing logo assets

/cc @iboonox

@kubernetes-sigs kubernetes-sigs deleted a comment from k8s-ci-robot Feb 9, 2020
@ahmetb ahmetb force-pushed the ahmetb:logo-docs branch from 0ec2095 to bc29ec5 Feb 9, 2020
@k8s-ci-robot k8s-ci-robot added size/M and removed size/S labels Feb 9, 2020
@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Feb 9, 2020

Codecov Report

Merging #500 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #500   +/-   ##
=======================================
  Coverage   58.51%   58.51%           
=======================================
  Files          22       22           
  Lines         969      969           
=======================================
  Hits          567      567           
  Misses        346      346           
  Partials       56       56

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 14f129f...1424982. Read the comment docs.

@ahmetb ahmetb force-pushed the ahmetb:logo-docs branch 2 times, most recently from 54da26a to 218215e Feb 9, 2020
Signed-off-by: Ahmet Alp Balkan <ahmetb@google.com>
@ahmetb ahmetb force-pushed the ahmetb:logo-docs branch from 218215e to 1424982 Feb 9, 2020
@@ -1,3 +1,6 @@
<img src="assets/logo/horizontal/color/krew-horizontal-color.png" width="480"
alt="Krew logo"/>

# krew

This comment has been minimized.

Copy link
@corneliusweig

corneliusweig Feb 10, 2020

Contributor

I wonder if we still need the heading, if the logo already says "krew".

This comment has been minimized.

Copy link
@ahmetb

ahmetb Feb 10, 2020

Author Member

That's actually still useful for SEO, since it's an h1.

@corneliusweig

This comment has been minimized.

Copy link
Contributor

corneliusweig commented Feb 11, 2020

/lgtm
/approve

cc @iboonox This looks so cool! 😎

@k8s-ci-robot

This comment has been minimized.

Copy link

k8s-ci-robot commented Feb 11, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmetb, corneliusweig

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [ahmetb,corneliusweig]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 5e5b941 into kubernetes-sigs:master Feb 11, 2020
3 of 4 checks passed
3 of 4 checks passed
build
Details
tide Not mergeable. Needs lgtm label.
Details
cla/linuxfoundation ahmetb authorized
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.