Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swap order of install and store receipt #503

Conversation

@corneliusweig
Copy link
Contributor

corneliusweig commented Feb 12, 2020

Install is much more likely to fail than storing the receipt.
Before, when the install failed, the new receipts was already
written to disk and not rolled back. Now, the receipt is only
stored when install has succeeded.

Fixes #502

Install is much more likely to fail than storing the receipt.
Before, when the install failed, the new receipts was already
written to disk and not rolled back. Now, the receipt is only
stored when install has succeeded.
@k8s-ci-robot

This comment has been minimized.

Copy link

k8s-ci-robot commented Feb 12, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: corneliusweig

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested review from ahmetb and soltysh Feb 12, 2020
@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Feb 12, 2020

Codecov Report

Merging #503 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #503   +/-   ##
=======================================
  Coverage   58.51%   58.51%           
=======================================
  Files          22       22           
  Lines         969      969           
=======================================
  Hits          567      567           
  Misses        346      346           
  Partials       56       56
Impacted Files Coverage Δ
internal/installation/upgrade.go 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 324f5ed...0925a76. Read the comment docs.

@ahmetb

This comment has been minimized.

Copy link
Member

ahmetb commented Feb 12, 2020

Nice.
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label Feb 12, 2020
@k8s-ci-robot k8s-ci-robot merged commit e5901f2 into kubernetes-sigs:master Feb 12, 2020
3 of 4 checks passed
3 of 4 checks passed
build
Details
tide Not mergeable. Needs lgtm label.
Details
cla/linuxfoundation corneliusweig authorized
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@corneliusweig corneliusweig deleted the corneliusweig:w/fix-receipt-for-failed-install branch Feb 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

4 participants
You can’t perform that action at this time.