Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move install docs to the website, add "moved" notices #522

Merged
merged 6 commits into from Mar 2, 2020

Conversation

@ahmetb
Copy link
Member

ahmetb commented Feb 28, 2020

  • refactor README, USER_GUIDE, DEVELOPER_GUIDE with notes indicating they are
    moved to the website.

  • move installation instructions from README to the user guide.

Related issue: #515

* refactor README, USER_GUIDE, DEVELOPER_GUIDE with notes indicating they are
  moved to the website.

* move installation instructions from README to the user guide.

Signed-off-by: Ahmet Alp Balkan <ahmetb@google.com>
@k8s-ci-robot k8s-ci-robot requested review from corneliusweig and soltysh Feb 28, 2020
@ahmetb ahmetb changed the title Move docs to the website Move install docs to the website, add "moved" notices Feb 28, 2020
@corneliusweig

This comment has been minimized.

Copy link
Contributor

corneliusweig commented Feb 28, 2020

We need to coordinate this with kubernetes/kubernetes#88593

Copy link
Contributor

corneliusweig left a comment

In general this looks good. However, I found a few paragraphs in our old docs which are no longer present in our new site. Can you have a look?

docs/NAMING_GUIDE.md Outdated Show resolved Hide resolved
docs/USER_GUIDE.md Show resolved Hide resolved
docs/USER_GUIDE.md Show resolved Hide resolved
docs/DEVELOPER_GUIDE.md Show resolved Hide resolved
docs/DEVELOPER_GUIDE.md Show resolved Hide resolved
docs/DEVELOPER_GUIDE.md Show resolved Hide resolved
ahmetb added 3 commits Mar 1, 2020
Signed-off-by: Ahmet Alp Balkan <ahmetb@google.com>
is -> has
Signed-off-by: Ahmet Alp Balkan <ahmetb@google.com>
Signed-off-by: Ahmet Alp Balkan <ahmetb@google.com>
@codecov-io

This comment was marked as off-topic.

Copy link

codecov-io commented Mar 1, 2020

Codecov Report

Merging #522 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #522   +/-   ##
=======================================
  Coverage   58.73%   58.73%           
=======================================
  Files          23       23           
  Lines        1013     1013           
=======================================
  Hits          595      595           
  Misses        359      359           
  Partials       59       59

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9b5620c...898bee6. Read the comment docs.

ahmetb added 2 commits Mar 1, 2020
Signed-off-by: Ahmet Alp Balkan <ahmetb@google.com>
fix
Signed-off-by: Ahmet Alp Balkan <ahmetb@google.com>
@ahmetb ahmetb mentioned this pull request Mar 2, 2020
7 of 8 tasks complete
@corneliusweig

This comment has been minimized.

Copy link
Contributor

corneliusweig commented Mar 2, 2020

Nice work!
/lgtm
/approve

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Mar 2, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmetb, corneliusweig

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [ahmetb,corneliusweig]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit ae43a27 into kubernetes-sigs:master Mar 2, 2020
8 of 9 checks passed
8 of 9 checks passed
build
Details
tide Not mergeable. Needs lgtm label.
Details
Header rules No header rules processed
Details
Pages changed 4 new files uploaded
Details
Redirect rules No redirect rules processed
Details
Mixed content No mixed content detected
Details
cla/linuxfoundation ahmetb authorized
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.