Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

site: add gitinfo and edit links to footer #525

Merged
merged 2 commits into from Mar 1, 2020

Conversation

@ahmetb
Copy link
Member

ahmetb commented Feb 28, 2020

  • pass page variables to footer

  • use .GitInfo and .File variables to show something like this in the footer
    for each page:

      [Edit Page] - Built from commit [xxxx]
    
  • enableGitInfo both locally and on Netlify builds

@k8s-ci-robot k8s-ci-robot requested review from corneliusweig and soltysh Feb 28, 2020
@ahmetb ahmetb force-pushed the ahmetb:site-footer-gitinfo branch from ffda53e to dc40bf3 Feb 28, 2020
@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Feb 28, 2020

Codecov Report

Merging #525 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #525   +/-   ##
=======================================
  Coverage   58.73%   58.73%           
=======================================
  Files          23       23           
  Lines        1013     1013           
=======================================
  Hits          595      595           
  Misses        359      359           
  Partials       59       59

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 42fa974...ddd0570. Read the comment docs.

@ahmetb ahmetb changed the title site: add gitinfo and edit links to footer [WIP] site: add gitinfo and edit links to footer Feb 28, 2020
@k8s-ci-robot k8s-ci-robot added size/M and removed size/XS labels Feb 28, 2020
* pass page variables to footer

* use .GitInfo and .File variables to show something like this in the footer
  for each page:

    [Edit Page] - Built from commit [xxxx]

* enableGitInfo both locally and on Netlify builds

Signed-off-by: Ahmet Alp Balkan <ahmetb@google.com>
@ahmetb ahmetb force-pushed the ahmetb:site-footer-gitinfo branch from dc40bf3 to 42fa974 Feb 28, 2020
@corneliusweig

This comment has been minimized.

Copy link
Contributor

corneliusweig commented Mar 1, 2020

Looks really nice! Thanks for your love to all the little details that make a great docs site!

/lgtm
/approve

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Mar 1, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmetb, corneliusweig

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [ahmetb,corneliusweig]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 4a1f75c into kubernetes-sigs:master Mar 1, 2020
8 of 9 checks passed
8 of 9 checks passed
build
Details
tide Not mergeable. Job continuous-integration/travis-ci/pr has not succeeded.
Details
Header rules No header rules processed
Details
Pages changed All files already uploaded
Details
Redirect rules No redirect rules processed
Details
Mixed content No mixed content detected
Details
cla/linuxfoundation corneliusweig authorized
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.