Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove codecov.io integration #553

Merged
merged 1 commit into from Mar 18, 2020

Conversation

@ahmetb
Copy link
Member

ahmetb commented Mar 17, 2020

After switching fully to GitHub Workflows we no longer use Codecov.io. We
also didn't really get much out of it.

/assign @corneliusweig

After switching fully to GitHub Workflows we no longer use Codecov.io. We
also didn't really get much out of it.

Signed-off-by: Ahmet Alp Balkan <ahmetb@google.com>
@corneliusweig

This comment has been minimized.

Copy link
Contributor

corneliusweig commented Mar 18, 2020

Can you add instructions to the readme how to get visual feedback for coverage? Like

go test -coverprofile=coverage.out
go tool cover -html=coverage.out
@ahmetb

This comment has been minimized.

Copy link
Member Author

ahmetb commented Mar 18, 2020

Aren't they the same for all go projects? Why need that?

@corneliusweig

This comment has been minimized.

Copy link
Contributor

corneliusweig commented Mar 18, 2020

They are the same, yes. But we could still put it in our developer docs, just in case sbdy is not familiar with go and wants to contribute.

@ahmetb

This comment has been minimized.

Copy link
Member Author

ahmetb commented Mar 18, 2020

Honestly, not sure why would it occur people to do that. I suspect most contributors don't read dev docs in full –so I'm inclined to leave it out. We review for missing tests anyway.

@corneliusweig

This comment has been minimized.

Copy link
Contributor

corneliusweig commented Mar 18, 2020

I sort of have a deja vu that we talked about once before. Let's leave as is until somebody complains :)
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm label Mar 18, 2020
@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Mar 18, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmetb, corneliusweig

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [ahmetb,corneliusweig]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 605a639 into kubernetes-sigs:master Mar 18, 2020
5 of 8 checks passed
5 of 8 checks passed
build
Details
Mixed content
Details
Redirect rules
Details
tide Not mergeable. Needs lgtm label.
Details
Header rules Deploy canceled
Details
Pages changed Deploy canceled
Details
cla/linuxfoundation ahmetb authorized
Details
deploy/netlify Deploy preview canceled.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.