Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trim and minify SVG assets

Merged
merged 1 commit into from Jun 7, 2020

Conversation

corneliusweig
Copy link
Contributor

@corneliusweig corneliusweig commented Jun 7, 2020

Fixes #533

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes label Jun 7, 2020
@k8s-ci-robot k8s-ci-robot requested review from ahmetb and soltysh Jun 7, 2020
@k8s-ci-robot k8s-ci-robot added approved size/XXL labels Jun 7, 2020
@ahmetb
Copy link
Member

ahmetb commented Jun 7, 2020

What sort of tool did you use to do this? 🤔

@ahmetb
Copy link
Member

ahmetb commented Jun 7, 2020

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm label Jun 7, 2020
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jun 7, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmetb, corneliusweig

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [ahmetb,corneliusweig]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 4ec386c into kubernetes-sigs:master Jun 7, 2020
7 of 8 checks passed
@corneliusweig
Copy link
Contributor Author

corneliusweig commented Jun 7, 2020

https://inkscape.org/ (has nice auto-trim) + https://jakearchibald.github.io/svgomg/ (lots of options to reduce size)

@corneliusweig corneliusweig deleted the w/trim-logo branch Jun 7, 2020
@ferhatelmas
Copy link
Contributor

ferhatelmas commented Jun 7, 2020

This might be enabled for the repo, that does this job automatically: https://github.com/marketplace/imgbot

@corneliusweig
Copy link
Contributor Author

corneliusweig commented Jun 7, 2020

imgbot looks nice. I wonder if there's a k8s policy about what bots can be enabled?

@ahmetb
Copy link
Member

ahmetb commented Jun 7, 2020

Since we don’t get images on an ongoing basis we prob don’t need a bot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cncf-cla: yes lgtm size/XXL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants