Skip to content
This repository has been archived by the owner on May 25, 2023. It is now read-only.

Set default PodGroup for Pods. #596

Merged
merged 1 commit into from Feb 25, 2019
Merged

Set default PodGroup for Pods. #596

merged 1 commit into from Feb 25, 2019

Conversation

k82cn
Copy link
Contributor

@k82cn k82cn commented Feb 21, 2019

Signed-off-by: Da K. Ma klaus1982.cn@gmail.com

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #588

Release note:

Made kube-batch do scheduling for Pod without PodGroup.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 21, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: k82cn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 21, 2019
@k82cn
Copy link
Contributor Author

k82cn commented Feb 21, 2019

I'll add an e2e test for this.

@k82cn
Copy link
Contributor Author

k82cn commented Feb 22, 2019

I'll add an e2e test for this.

Updated util to schedule ReplicaSet by kube-batch :)

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 24, 2019
Signed-off-by: Da K. Ma <klaus1982.cn@gmail.com>
@k82cn k82cn added the lgtm Indicates that a PR is ready to be merged. label Feb 25, 2019
@k8s-ci-robot k8s-ci-robot merged commit 36c35cc into kubernetes-retired:master Feb 25, 2019
@k82cn k82cn deleted the kb_588 branch February 25, 2019 03:41
k8s-ci-robot added a commit that referenced this pull request Feb 25, 2019
…ream-release-0.4

Automated cherry pick of #596: Set default PodGroup for Pods.
kevin-wangzefeng pushed a commit to kevin-wangzefeng/scheduler that referenced this pull request Jun 28, 2019
kevin-wangzefeng pushed a commit to kevin-wangzefeng/scheduler that referenced this pull request Jun 28, 2019
kevin-wangzefeng pushed a commit to kevin-wangzefeng/scheduler that referenced this pull request Jun 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Pods without PodGroup
2 participants