Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shadow pod group derives min member from pod annotations #908

Conversation

@mateuszlitwin
Copy link
Contributor

@mateuszlitwin mateuszlitwin commented Nov 18, 2019

What this PR does / why we need it:
Added scheduling.k8s.io/group-min-member annotation that allows to specify min member for the shadow pod group.

Requiring users to learn new custom resource PodGroup and properly handling clean up of such resource is nontrivial and time consuming. In common use case user just want create a batch of pods that will be allocated together at the same time. Extending shadow pod group capabilities could be a solution for this.

Which issue(s) this PR fixes:
Fixes #905

Special notes for your reviewer:

Release note:

Shadow pod group has min member derived from the pod annotation "scheduling.k8s.io/group-min-member". This is backward compatible change - if annotation is not specified, then min member defaults to 1. If pod has normal pod group, then this annotation will be ignored, and min member from the pod group object will be used instead.
@k8s-ci-robot
Copy link
Contributor

@k8s-ci-robot k8s-ci-robot commented Nov 18, 2019

Hi @mateuszlitwin. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot requested review from hex108 and hzxuzhonghu Nov 18, 2019
@k8s-ci-robot k8s-ci-robot added the size/L label Nov 18, 2019
@mateuszlitwin mateuszlitwin force-pushed the mateuszlitwin:mlitwin-min-group-annotation branch from 77dd62e to 2dd2561 Nov 18, 2019
@k8s-ci-robot k8s-ci-robot added size/M and removed size/L labels Nov 18, 2019
@mateuszlitwin mateuszlitwin force-pushed the mateuszlitwin:mlitwin-min-group-annotation branch from 2dd2561 to 8634c1d Nov 18, 2019
@mateuszlitwin mateuszlitwin marked this pull request as ready for review Nov 18, 2019
@mateuszlitwin
Copy link
Contributor Author

@mateuszlitwin mateuszlitwin commented Nov 18, 2019

/assign @k82cn

@mateuszlitwin mateuszlitwin force-pushed the mateuszlitwin:mlitwin-min-group-annotation branch from 8634c1d to 88cb8b2 Nov 18, 2019
@k82cn
Copy link
Contributor

@k82cn k82cn commented Nov 19, 2019

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm label Nov 19, 2019
@k8s-ci-robot
Copy link
Contributor

@k8s-ci-robot k8s-ci-robot commented Nov 19, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: k82cn, mateuszlitwin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k82cn
Copy link
Contributor

@k82cn k82cn commented Nov 19, 2019

/ok-to-test

@k8s-ci-robot k8s-ci-robot merged commit f04c7d2 into kubernetes-sigs:master Nov 19, 2019
4 checks passed
4 checks passed
cla/linuxfoundation mateuszlitwin authorized
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
pull-kube-batch-verify Job succeeded.
Details
tide In merge pool.
Details
@mateuszlitwin mateuszlitwin deleted the mateuszlitwin:mlitwin-min-group-annotation branch Nov 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants