Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document Prometheus setup and usage to export metrics #1244

Closed
camilamacedo86 opened this issue Dec 6, 2019 · 4 comments · Fixed by #1245
Closed

Document Prometheus setup and usage to export metrics #1244

camilamacedo86 opened this issue Dec 6, 2019 · 4 comments · Fixed by #1245
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/documentation Categorizes issue or PR as related to documentation.

Comments

@camilamacedo86
Copy link
Member

We change the previous set up in order to support the usage of Prometheus Operator, however, is missing doc it. All steps and information are in the PR: #1030.
@camilamacedo86 camilamacedo86 added the kind/feature Categorizes issue or PR as related to a new feature. label Dec 6, 2019
@camilamacedo86
Copy link
Member Author

camilamacedo86 commented Dec 6, 2019 •
edited

/assign @camilamacedo86

@mengqiy
Copy link
Member

mengqiy commented Dec 6, 2019

It seems these 2 pieces are no longer needed.

kubebuilder/testdata/project-v2/config/default/kustomization.yaml

Line 29 in 3ec07ea

# manager_prometheus_metrics_patch.yaml should be enabled.
and

kubebuilder/testdata/project-v2/config/default/kustomization.yaml

Lines 35 to 36 in 3ec07ea

# manager_prometheus_metrics_patch.yaml should be enabled.
#- manager_prometheus_metrics_patch.yaml

We need to cleanup comments in kustomization.yaml.

@mengqiy mengqiy added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/documentation Categorizes issue or PR as related to documentation. and removed kind/feature Categorizes issue or PR as related to a new feature. labels Dec 6, 2019
@camilamacedo86
Copy link
Member Author

Thanks for point out the places @mengqiy

@camilamacedo86 camilamacedo86 mentioned this issue Dec 6, 2019
Merged
@mengqiy
Copy link
Member

mengqiy commented Dec 9, 2019

The code scoffolding manager_prometheus_metrics_patch won't be needed either.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/documentation Categorizes issue or PR as related to documentation.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add doc to setup Prometheus via operator and remove ref of manager_p… camilamacedo86/kubebuilder
2 participants
@mengqiy @camilamacedo86