Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid rewriting template values, mark them as const #1190

Merged
merged 2 commits into from Nov 14, 2019
Merged

Avoid rewriting template values, mark them as const #1190

merged 2 commits into from Nov 14, 2019

Commits on Nov 12, 2019

  1. Don't rewrite potentially shared values 

    Make them constant and use a local var.
    @justinsb
    justinsb committed Nov 12, 2019
    Copy the full SHA
    7623c75 View commit details
    Browse the repository at this point in the history

  2. Mark other templates as const also 

    To prevent the previous problem from being introduced elsewhere.
    @justinsb
    justinsb committed Nov 12, 2019
    Copy the full SHA
    7b632b2 View commit details
    Browse the repository at this point in the history